From a38953d69f59226d7451d138b7436bbb2c290628 Mon Sep 17 00:00:00 2001 From: wuzeyu <1223318623@qq.com> Date: 星期二, 22 十月 2024 10:41:39 +0800 Subject: [PATCH] 优化代码 --- pipIrr-platform/pipIrr-web/pipIrr-web-remote/src/main/java/com/dy/pipIrrRemote/valve/ValveCtrl.java | 93 ++++++++++++++++++++++++++++++---------------- 1 files changed, 60 insertions(+), 33 deletions(-) diff --git a/pipIrr-platform/pipIrr-web/pipIrr-web-remote/src/main/java/com/dy/pipIrrRemote/valve/ValveCtrl.java b/pipIrr-platform/pipIrr-web/pipIrr-web-remote/src/main/java/com/dy/pipIrrRemote/valve/ValveCtrl.java index 648354f..8f205cb 100644 --- a/pipIrr-platform/pipIrr-web/pipIrr-web-remote/src/main/java/com/dy/pipIrrRemote/valve/ValveCtrl.java +++ b/pipIrr-platform/pipIrr-web/pipIrr-web-remote/src/main/java/com/dy/pipIrrRemote/valve/ValveCtrl.java @@ -2,6 +2,7 @@ import com.alibaba.fastjson2.JSONObject; import com.dy.common.aop.SsoAop; +import com.dy.common.multiDataSource.DataSourceContext; import com.dy.common.mw.protocol.p206V1_0_0.CodeV1_0_1; import com.dy.common.mw.protocol.p206V1_0_0.downVos.*; import com.dy.common.mw.protocol.p206V202404.CodeV202404; @@ -22,6 +23,7 @@ import com.dy.pipIrrRemote.common.CommandSv; import com.dy.pipIrrRemote.common.dto.*; import com.dy.pipIrrRemote.result.RemoteResultCode; +import com.dy.pipIrrRemote.valve.dto.deleteUnclosedParam; import io.swagger.v3.oas.annotations.tags.Tag; import jakarta.validation.Valid; import lombok.extern.slf4j.Slf4j; @@ -110,10 +112,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -241,10 +244,11 @@ } //Long intakeId = job_rtu.getLong("intakeId"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); String commandCode = null; @@ -359,10 +363,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -479,11 +484,11 @@ return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_EXIST.getMessage()); } String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } - + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); String commandCode = null; @@ -601,10 +606,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -704,10 +710,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -814,10 +821,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -929,10 +937,11 @@ } String rtuAddr = job_rtu.getString("rtuAddr"); String protocol = job_rtu.getString("protocol"); - String orgTag = job_rtu.getString("orgTag"); - if(orgTag == null) { - return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); - } + //String orgTag = job_rtu.getString("orgTag"); + //if(orgTag == null) { + // return BaseResponseUtils.buildErrorMsg(RemoteResultCode.RTU_NOT_SET_DATA_SOURCE.getMessage()); + //} + String orgTag = DataSourceContext.get(); comSendUrl = env.getProperty(pro_mw + "." + orgTag + "." + key_mw); // 鐢熸垚璁㈠崟鍙� @@ -1002,6 +1011,24 @@ } /** + * 寮哄埗鍥犳鏈叧闃�璁板綍锛氫负鎸囧畾锛堥榾鎺у櫒鍦板潃銆佹按鍗$紪鍙枫�佹棤鍏抽榾璁板綍锛夊紑鍏抽榾鏈�鏂拌褰曟坊鍔犲叧闃�鏃堕棿锛屼娇涔嬩笉鍦ㄦ湭鍏抽榾璁板綍涓樉绀� + * @param po + * @param bindingResult + * @return + */ + @PostMapping(path = "deleteUnclosed", consumes = MediaType.APPLICATION_JSON_VALUE) + @Transactional(rollbackFor = Exception.class) + @SsoAop() + public BaseResponse<Boolean> deleteUnclosed(@RequestBody @Valid deleteUnclosedParam po, BindingResult bindingResult) { + if(bindingResult != null && bindingResult.hasErrors()){ + return BaseResponseUtils.buildFail(Objects.requireNonNull(bindingResult.getFieldError()).getDefaultMessage()); + } + + commandSv.addClostTime(po.getRtuAddr(), po.getVcNum()); + return BaseResponseUtils.buildSuccess(); + } + + /** * 骞冲彴杩滅▼鍏呭�� * @param po * @param bindingResult -- Gitblit v1.8.0