From 317dabcf4901fced12e75c0d3b442607fb479bec Mon Sep 17 00:00:00 2001 From: zhubaomin <zhubaomin> Date: 星期四, 03 四月 2025 14:18:09 +0800 Subject: [PATCH] 代码优化 --- pipIrr-platform/pipIrr-common/src/main/java/com/dy/common/mw/protocol/p206V1/parse/Cd_83_Up.java | 48 ++++++++++++++++++++++++++++++------------------ 1 files changed, 30 insertions(+), 18 deletions(-) diff --git a/pipIrr-platform/pipIrr-common/src/main/java/com/dy/common/mw/protocol/p206V1/parse/Cd_83_Up.java b/pipIrr-platform/pipIrr-common/src/main/java/com/dy/common/mw/protocol/p206V1/parse/Cd_83_Up.java index 75ca70d..1f722b4 100644 --- a/pipIrr-platform/pipIrr-common/src/main/java/com/dy/common/mw/protocol/p206V1/parse/Cd_83_Up.java +++ b/pipIrr-platform/pipIrr-common/src/main/java/com/dy/common/mw/protocol/p206V1/parse/Cd_83_Up.java @@ -3,7 +3,6 @@ import com.dy.common.mw.protocol.*; import com.dy.common.mw.protocol.p206V1.*; import com.dy.common.mw.protocol.p206V1.parse.global.GlParse; -import com.dy.common.mw.protocol.p206V1.upVos.DataCd81Vo; import com.dy.common.mw.protocol.p206V1.upVos.DataCd83CloseVo; import com.dy.common.mw.protocol.p206V1.upVos.DataCd83OpenVo; import com.dy.common.mw.protocol.rtuState.ValveStateInfo; @@ -25,7 +24,7 @@ @Override public MidResult[] parse(Boolean isLowPower, CodeParseParams params, CodeParseCallback callback)throws Exception { ParseParamsForUpV1 para = (ParseParamsForUpV1)params ; - int bsLen = new CommonV1().parseDataLen(para.upBuffer) ; + int bsLen = new CommonV1().parseDataLen4P206(para.upBuffer) ; if(bsLen > 0){ this.doParse(para.upBuffer, bsLen, @@ -86,8 +85,8 @@ } } - callback.callback(midRs.reportOrResponse_trueOrFalse); - return new MidResult[]{midRs, confirmCommand} ; + callback.callback(midRs.reportOrResponse_trueOrFalse, para.data.subData==null?null:((DataV1)(para.data.subData)).subData); + return new MidResult[]{confirmCommand, midRs} ; } /** * 鎵ц鍒嗘瀽 @@ -117,20 +116,26 @@ short index = ProtocolConstantV206V1.dataIndex + 1 ; //绱娴侀噺锛�5瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0~99999999.99锛屽崟浣嶄负m3銆� - int tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 4) ; - cdData.totalAmount = tpInt/100.0 ; + long tpLong = ByteUtil.BCD2Long_LE(bs, index, index + 4) ; + cdData.totalAmount = tpLong/100.0 ; index += 5 ; //鐢ㄦ按鎴峰彿鏁版嵁鏍煎紡锛�8瀛楄妭浣庝綅鍦ㄥ墠楂樹綅鍦ㄥ悗銆� + if(ByteUtil.bytesIsAll0xFF(bs, index, 8)){ + throw new Exception("IC鍗″彿鏁版嵁鏍煎紡閿欒锛�8瀛楄妭鍏ㄩ儴涓�0xFF锛岃垗寮冩暟鎹�") ; + } cdData.icCardNo = GlParse.parseIcCardNo(bs, index) ; index += 8 ; //IC鍗″彿鏍煎紡锛�4瀛楄妭HEX鐮佷綆浣嶅湪鍓嶉珮浣嶅湪鍚庛�� + if(ByteUtil.bytesIsAll0xFF(bs, index, 4)){ + throw new Exception("IC鍦板潃鏁版嵁鏍煎紡閿欒锛�4瀛楄妭鍏ㄩ儴涓�0xFF锛岃垗寮冩暟鎹�") ; + } cdData.icCardAddr = ByteUtil.bytes2Hex_LE(bs, false, index, 4) ; index += 4 ; //鐢ㄦ按鎴蜂綑棰濓細鐢ㄦ埛浣欓4瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0.00~999999.99锛屽崟浣嶄负鍏冦�� - tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 3) ; + int tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 3) ; cdData.remainMoney = tpInt/100.0 ; index += 4 ; @@ -155,21 +160,27 @@ short index = ProtocolConstantV206V1.dataIndex + 1 ; //绱娴侀噺锛�5瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0~9999999999锛屽崟浣嶄负m3銆� - int tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 4) ; - cdData.totalAmount = tpInt/100.0 ; + long tpLong = ByteUtil.BCD2Long_LE(bs, index, index + 4) ; + cdData.totalAmount = tpLong/100.0 ; index += 5 ; //鐢ㄦ按鎴峰彿鏁版嵁鏍煎紡锛�8瀛楄妭浣庝綅鍦ㄥ墠楂樹綅鍦ㄥ悗銆� + if(ByteUtil.bytesIsAll0xFF(bs, index, 8)){ + throw new Exception("IC鍗″彿鏁版嵁鏍煎紡閿欒锛�8瀛楄妭鍏ㄩ儴涓�0xFF锛岃垗寮冩暟鎹�") ; + } cdData.icCardNo = GlParse.parseIcCardNo(bs, index) ; index += 8 ; //IC鍗″彿鏍煎紡锛�4瀛楄妭HEX鐮佷綆浣嶅湪鍓嶉珮浣嶅湪鍚庛�� + if(ByteUtil.bytesIsAll0xFF(bs, index, 4)){ + throw new Exception("IC鍦板潃鏁版嵁鏍煎紡閿欒锛�4瀛楄妭鍏ㄩ儴涓�0xFF锛岃垗寮冩暟鎹�") ; + } cdData.icCardAddr = ByteUtil.bytes2Hex_LE(bs, false, index, 4) ; index += 4 ; //鐢ㄦ按鎴蜂綑棰濓細鐢ㄦ埛浣欓4瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0.00~999999.99锛屽崟浣嶄负鍏冦�� - tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 3) ; - cdData.remainMoney = tpInt/100.0 ; + tpLong = ByteUtil.BCD2Long_LE(bs, index, index + 3) ; + cdData.remainMoney = tpLong/100.0 ; index += 4 ; //鐢ㄦ按鎴风敤姘村紑濮嬫椂闂达細6瀛楄妭BCD鐮侊紝椤哄簭鏄勾鏈堟棩鏃跺垎绉掞紝鍏朵腑鍏厓骞�=2000+骞淬�� @@ -181,17 +192,17 @@ index += 6 ; //鐢ㄦ按鎴锋湰娆$敤姘撮噺锛氱疮璁℃祦閲�5瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0~9999999999锛屽崟浣嶄负m3銆� - tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 4) ; - cdData.thisAmount = tpInt/100.0 ; + tpLong = ByteUtil.BCD2Long_LE(bs, index, index + 4) ; + cdData.thisAmount = tpLong/100.0 ; index += 5 ; //鐢ㄦ按鎴锋湰娆℃秷璐归噾棰濓細鐢ㄦ埛浣欓4瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0.00~999999.99锛屽崟浣嶄负鍏冦�� - tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 3) ; - cdData.thisMoney = tpInt/100.0 ; + tpLong = ByteUtil.BCD2Long_LE(bs, index, index + 3) ; + cdData.thisMoney = tpLong/100.0 ; index += 4 ; //鐢ㄦ按鎴锋湰娆$敤姘存椂闀匡細鐢ㄦ按鏃堕暱2瀛楄妭BCD鐮侊紝鍙栧�艰寖鍥�0~9999锛屽崟浣嶄负鍒嗛挓銆� - tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 1) ; + int tpInt = ByteUtil.BCD2Int_LE(bs, index, index + 1) ; cdData.thisTime = tpInt; index += 2 ; @@ -217,13 +228,14 @@ Cd_83_Up obj = new Cd_83_Up() ; //涓嬮潰涓ゆ潯涓婃姤鏁版嵁锛孖C鍗$紪鐮侀兘鏄潪BCD缂栫爜鑰屽紓甯� //String hex = "683C68B08485353448830200000000001000282353FE739444000001000313000101211615000101210000000000000000000200019000011518000101210A7B16"; - String hex = "683C68B05301154CEA8306001000000004343638483BBBB9E0001000001603000101215907000101210000000000000000000500019000015308000101210AF716"; + //String hex = "683C68B05301154CEA8306001000000004343638483BBBB9E0001000001603000101215907000101210000000000000000000500019000015308000101210AF716"; + String hex = "683868B0532328B90083074065840000FE00061010282353535B7F7691590100404022231024737F3F3F1FFF957296944239050000390001900000F916"; byte[] bs = ByteUtil.hex2Bytes(hex) ; Data data = new Data() ; data.setSubData(new DataV1()) ; - int bsLen = new CommonV1().parseDataLen(bs) ; + int bsLen = new CommonV1().parseDataLen4P206(bs) ; if(bsLen > 0){ try { obj.doParse(bs, -- Gitblit v1.8.0